Merge pull request #21 from Inxton/bulk_data_validation_fix_when_not_modified

* validation has been reported when write status was NoChange

Author: peterbarancek

src/TcoData/src/Wpf/TcoData.Wpf/Data/BulkData/Helpers/PropertyHelper.cs

@@ -7,6 +7,28 @@
 
 namespace TcoData.Helpers
 {
+    using System;
+    using System.Linq.Expressions;
+
+    public static class SymbolHelper
+    {
+        public static string GetFullPath<T>(Expression<Func<T>> expr)
+        {
+            var memberExpr = expr.Body as MemberExpression;
+            if (memberExpr == null)
+                throw new ArgumentException("Expression must be a MemberExpression");
+
+            var parts = new System.Collections.Generic.List<string>();
+            while (memberExpr != null)
+            {
+                parts.Insert(0, memberExpr.Member.Name);
+                memberExpr = memberExpr.Expression as MemberExpression;
+            }
+
+            return string.Join(".", parts);
+        }
+    }
+
     public static class PropertyHelper
     {
         public static string GetPropertyName<T, TProperty>(Expression<Func<T, TProperty>> property)

src/TcoData/src/Wpf/TcoData.Wpf/Data/BulkData/Models/BulkTraversalModel.cs

@@ -203,6 +203,8 @@ public void ApplyWriteRequests()
 
             if (!writeItems.Any())
                 return;
+            // Create a HashSet for fast symbol lookup
+            var modifiedSymbols = new HashSet<string>(writeItems.Where(p=>p.WriteStatus == BulkItemWriteStatus.Modified).Select(i => i.Symbol));
 
             IEnumerable<TEntity> allEntities = new List<TEntity>();
             if (WriteToAllEntities)
@@ -236,11 +238,11 @@ public void ApplyWriteRequests()
                     if (validations != null && validations.Any())
                     {
                         LastValidationLog = string.Join(Environment.NewLine, validations
-                            .Where(v => v.Failed == true)
+                            .Where(v => v.Failed == true && modifiedSymbols.Any(symbol => v.Error.Contains(symbol)))
                             .Select(v => $"❌ {v.Error}"));
                     }
 
-                    if (validations.Any(p => p.Failed == true))
+                    if (validations.Any(v => v.Failed && modifiedSymbols.Any(symbol => v.Error.Contains(symbol))))
                     {
                         return;
                     }

src/TcoData/tests/Sandbox.TcoData.Wpf/App.xaml.cs

@@ -99,9 +99,9 @@ public App()
             {
                 return new DataItemValidation[]
                 {
-        new DataItemValidation($"'{nameof(data.sampleData.SampleInt)}' must be greater than 0", data.sampleData.SampleInt <= 0),
+        new DataItemValidation($"'{SymbolHelper.GetFullPath(() =>data.sampleData.SampleInt)}' must be greater than 0", data.sampleData.SampleInt <= 0),
 
-        new DataItemValidation($"'{nameof(data.sampleData.SampleInt2)}' must be less than 0", data.sampleData.SampleInt2 > 0)
+        new DataItemValidation($"'{SymbolHelper.GetFullPath(() =>data.sampleData.SampleInt2)}' must be less than 0", data.sampleData.SampleInt2 > 0)
                 };
             };