Skip to content

NULL checks for context and parent should use IsValid instead of null check expression #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

NULL checks for context and parent should use IsValid instead of null check expression #652

wants to merge 2 commits into from

Conversation

@PTKu
Copy link
Contributor

@PTKu PTKu commented Apr 5, 2025 •
edited
Loading

Any expression where we check for NULL context || NULL parent object should be replaces with

IF(obj.GetContext().IsValid()) THEN ...

or

IF(obj.GetParent().IsValid()) THEN ...

closes #651

@PTKu PTKu linked an issue Apr 5, 2025 that may be closed by this pull request
NULL checks for context and parent should use IsValid instead of null check expression #651
Open
@PTKu PTKu requested a review from TomKovac April 5, 2025 04:54
@PTKu
Merge branch 'dev' into 651-null-checks-for-context-and-parent-should…
5cfa46f 
…-use-isvalid-instead-of-null-check-expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomKovac TomKovac Awaiting requested review from TomKovac

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NULL checks for context and parent should use IsValid instead of null check expression

2 participants

@PTKu