refactor: update Dockerfiles to Node 18.16 and remove un needed code

Author: Inushin

AngularFrontend/Dockerfile

@@ -1,12 +1,10 @@
 # Stage 1: Build frontend
-FROM node:fermium as build-stage
+FROM node:18.16.0-alpine3.17 as build-stage
 WORKDIR ./app
 COPY ./package*.json /app/
 RUN npm ci
 COPY ./ /app/
-# Create Angular environment files in build time based in BRANCH and BUILD args
-ARG BRANCH
-RUN node set-env.js $BRANCH
+
 RUN npm run build -- --output-path=./dist/out --output-hashing=all
 
 # Stage 2: Serve it using Ngnix

AngularFrontend/README.md

@@ -1,6 +1,6 @@
 # AngularFrontend
 
-This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 15.2.6.
+This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 14.0.2.
 
 ## Development server
 

AngularFrontend/set-env.js

@@ -1,22 +1,18 @@
-# An ARG declared before the FROM instruction cannot be used after the FROM
-ARG TAG
-FROM node:$TAG
+FROM node:18.16.0-alpine3.17
 
 # Create app directory
 RUN mkdir -p /home/node/app/node_modules && chown -R node:node /home/node/app
 WORKDIR /home/node/app
 
 # Install app dependencies
-# A wildcard is used to ensure both package.json AND package-lock.json are copied
-# where available (npm@5+)
 COPY --chown=node:node package*.json ./
 # COPY --chown=node:node . .
 USER node
 
 RUN npm install
 
 # If you are building your code for production
-# RUN npm ci --only=production
+RUN npm ci
 
 # Bundle app source
 COPY --chown=node:node . .

NodeBackend/Dockerfile

@@ -5,7 +5,6 @@ services:
     container_name: angularfrontend
     build:
       context: ./AngularFrontend
-      args: [BRANCH=develop]
       dockerfile: ./Dockerfile
   nginx:
     container_name: middlenginx
@@ -17,12 +16,11 @@ services:
     volumes:
       - ./nginx.middle.conf:/etc/nginx/conf.d/default.conf:rw
     depends_on:
-      - nodebackend
+      - backend
   backend:
     container_name: nodebackend
     build:
       context: ./NodeBackend
-      args: [TAG=fermium]
       dockerfile: ./Dockerfile
     ports:
       - "3000:3000"