Skip to content

Amend documentation in Builtins.Internal about budgeting and invariants on Bytestring builtins #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

SeungheonOh
Copy link
Collaborator

@SeungheonOh SeungheonOh commented May 20, 2025

Adds more notes in Builtins.Internal:

  1. notes about execution budget and script failure due to that
  2. Invariants on replicateByte and integerToByteString

I will add notes on which function have dynamic costing and which doesn't later today

@SeungheonOh SeungheonOh requested a review from kwxm May 20, 2025 23:23
@SeungheonOh SeungheonOh added the No Changelog Required Add this to skip the Changelog Check label May 21, 2025
Copy link
Contributor

@kwxm kwxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed this. Looks good!

@SeungheonOh SeungheonOh force-pushed the seungheonoh/7096-amendment branch 2 times, most recently from 7840994 to 6b4a4f3 Compare June 8, 2025 07:38
@SeungheonOh SeungheonOh enabled auto-merge (squash) June 8, 2025 07:39
Copy link
Contributor

github-actions bot commented Jun 8, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://IntersectMBO.github.io/plutus/pr-preview/pr-7109/

Built to branch gh-pages at 2025-06-08 08:45 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@SeungheonOh SeungheonOh force-pushed the seungheonoh/7096-amendment branch from 6b4a4f3 to 075f674 Compare June 8, 2025 08:42
@SeungheonOh SeungheonOh merged commit 7e21569 into master Jun 8, 2025
7 checks passed
@SeungheonOh SeungheonOh deleted the seungheonoh/7096-amendment branch June 8, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants