Model IO #9
Merged
Model IO #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
reviewed
Sep 18, 2023
phadej
force-pushed
the
model-io
branch
3 times, most recently
from
396cb7f to
04290ab
Compare
dcoutts
approved these changes
Oct 2, 2023
with initial type-class for abstracting over real and model io implementation and a single "smoke" test
dcoutts
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Yes this looks great. It's a nice simple wrapper around the pure model, to give a model that implements the imperative mutable API style. And then a class abstracting over (most of) that imperative mutable API to write QC tests against, with an example "classic" QC property, using the class.
One minor suggestion below.
Co-authored-by: Duncan Coutts <duncan@well-typed.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.