Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Expired governance action page/link does not show the details #2164

Open
spannercode opened this issue Oct 17, 2024 · 1 comment
Open
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar

Comments

@spannercode
Copy link
Contributor

Area

Voting Pillar

Domain

gov.tools

Which wallet were you using?

N/A

Context

The link of expired governance action shows a page saying the governance action with id does not exist.

Since the link to the governance action could have been shared, the page should show the governance action details even though the action has expired.

Steps to reproduce

  1. Visit the following link:
    https://gov.tools/governance_actions/15f82a365bdee483a4b03873a40d3829cc88c048ff3703e11bd01dd9e035c916#0
  2. Check that transaction hash does exist
    https://cardanoscan.io/transaction/15f82a365bdee483a4b03873a40d3829cc88c048ff3703e11bd01dd9e035c916?tab=govActions

Actual behavior

Governance action with id ... does not exist.
Screenshot 2024-10-17 at 08 49 03

Expected behavior

Even though the governance action has expired, the page should still load with all the details of the governance action.

@spannercode spannercode added the 🐛 Bug Something isn't working label Oct 17, 2024
@m-i-k-e
Copy link

m-i-k-e commented Oct 17, 2024

Governance Actions of any state need to show up in the GA search page and also the state of the action needs to show up in the GA detail page. Currently, there are 3 states:
Proposed
Active (Votable)
Expired

We are working on a design for this, I will check and see if it's ready @bosko-m @MSzalowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Status: No status
Status: To do
Development

No branches or pull requests

2 participants