Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of mapPartial #446

Closed
Tracked by #282
WhatisRT opened this issue Jun 4, 2024 · 4 comments · Fixed by #460
Closed
Tracked by #282

Naming of mapPartial #446

WhatisRT opened this issue Jun 4, 2024 · 4 comments · Fixed by #460
Labels
discussion notation Issues with notation in the PDF
Milestone

Comments

@WhatisRT
Copy link
Collaborator

WhatisRT commented Jun 4, 2024

mapPartial isn't a a name that will be understood without explanation. Should we rename it to something else? Are there other good options, like a set-builder notation?

@WhatisRT WhatisRT changed the title mapPartial -> ??? (maybe we can have a custom set-builder notation?) Naming of mapPartial Jun 4, 2024
@WhatisRT WhatisRT added discussion notation Issues with notation in the PDF discuss in meeting Things to discuss in the next formal ledger meeting labels Jun 4, 2024
@WhatisRT WhatisRT added this to the May - Jul milestone Jun 4, 2024
@WhatisRT
Copy link
Collaborator Author

WhatisRT commented Jun 4, 2024

We discussed some alternative options like map*, map? and mapPartialFun. Classical notation for mapping a set with a function would be f(X) or f[X] where X is a set, but that doesn't really apply here.

For now, we decided to leave it as it is and add a description for mapPartial in the Notation Section.

@WhatisRT WhatisRT removed the discuss in meeting Things to discuss in the next formal ledger meeting label Jun 4, 2024
@jmchapman
Copy link

mapMaybe?

@WhatisRT
Copy link
Collaborator Author

WhatisRT commented Jun 7, 2024

I guess that's another option, but it doesn't save us from having to explain it. In which case, sticking with mapPartial is a bit easier.

@jmchapman
Copy link

It still requires explanation but it's Haskell terminology so should be more familiar to some...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion notation Issues with notation in the PDF
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants