Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos #5708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Open

fix some typos #5708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bench/cardano-topology/app/cardano-topology.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ main = do
--------------------------------------------------------------------------------

-- | Locations from the CLI are parsed first using the "legacy mode" for
-- backward compatiblity, in this mode locations have a default AWS region that
-- backward compatibility, in this mode locations have a default AWS region that
-- are the ones cardano-ops is using. The new format is either "loopback" or a
-- supported AWS Region.
cliLocation :: String -> Either String Topo.Location
Expand Down
2 changes: 1 addition & 1 deletion bench/locli/src/Cardano/Analysis/API/Chain.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import Cardano.Analysis.API.Context
import Cardano.Analysis.API.Ground


-- | A pretty obvious (and dangerously assumptious) interpretation of an absolute slot number.
-- | A pretty obvious (and dangerously assumptions) interpretation of an absolute slot number.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the previous one was correct.

-- This is wrong, if you consider the reasons why epochLength can change.
unsafeParseSlot :: Genesis -> SlotNo -> (EpochNo, EpochSlot)
unsafeParseSlot Genesis{..} slot = (EpochNo epoch, EpochSlot epochSlot)
Expand Down
2 changes: 1 addition & 1 deletion bench/locli/src/Cardano/Command.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ runChainCommand s@State{sMultiClusterPerf=Just (MultiClusterPerf perf)}
& firstExceptT (CommandError c)
pure s
runChainCommand _ c@RenderMultiClusterPerf{} = missingCommandData c
["multi-run cluster preformance stats"]
["multi-run cluster performance stats"]

runChainCommand s c@ComputeSummary = do
progress "summary" (Q "summarising a run")
Expand Down
2 changes: 1 addition & 1 deletion bench/tx-generator/src/Cardano/TxGenerator/Genesis.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{- HLINT ignore "Use map" -}

-- | This module provides means to secure funds that are given in genesis.
-- To secure a fund, the key locking the transaction ouput in genesis has to be provided.
-- To secure a fund, the key locking the transaction output in genesis has to be provided.
module Cardano.TxGenerator.Genesis
( genesisInitialFunds
, genesisInitialFundForKey
Expand Down
2 changes: 1 addition & 1 deletion bench/tx-generator/src/Cardano/TxGenerator/Tx.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type CreateAndStore m era = Lovelace -> (TxOut CtxTx era, TxIx -> TxId
-- | 'CreateAndStoreList' is meant to represent building a transaction
-- and presenting a function to carry out the needed side effects.
-- This type alias is also only used in "Cardano.Benchmarking.Wallet".
-- The @split@ parameter seems to actualy be used for not much more
-- The @split@ parameter seems to actually be used for not much more
-- than lists and records containing lists.
type CreateAndStoreList m era split = split -> ([TxOut CtxTx era], TxId -> m ())

Expand Down
4 changes: 2 additions & 2 deletions cardano-tracer/docs/cardano-tracer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ where:

- `/tmp/forwarder.sock` is a path to the local socket on machine `A` _and_ a path to the local socket on machine `D`,
- `john` is a user name you use to login on machine `D`,
- `109.75.33.121` is an IP-adress of machine `D`.
- `109.75.33.121` is an IP-address of machine `D`.

Now run the same command on machines `B` and `C` to connect corresponding nodes with the same `cardano-tracer` working on machine `D`.

Expand Down Expand Up @@ -244,7 +244,7 @@ There is another way to connect `cardano-tracer` to your nodes: the `cardano-tra

As you see, the tag in `network` field is `ConnectTo` now, which means that `cardano-tracer` works as a client: it _establishes_ network connections with your local nodes via the local sockets `/tmp/cardano-node-*.sock`. In this case each socket is used by a particular node.

Please use `ConnectTo`-based scenario only if you really need it. Otherwise, it is **highly recommended** to use `AcceptAt`-based scenario. The reason is easier maintainance. Suppose you have 3 working nodes, and they are connected to the same `cardano-tracer`. And then you want to connect 4-th node to it. If `cardano-tracer` is configured using `AcceptAt`, you shouldn't change its configuration - you just connect your 4-th node to it. But if `cardano-tracer` is configured using `ConnectTo`, you should add path to 4-th socket in its configuration file and then restart `cardano-tracer` process.
Please use `ConnectTo`-based scenario only if you really need it. Otherwise, it is **highly recommended** to use `AcceptAt`-based scenario. The reason is easier maintenance. Suppose you have 3 working nodes, and they are connected to the same `cardano-tracer`. And then you want to connect 4-th node to it. If `cardano-tracer` is configured using `AcceptAt`, you shouldn't change its configuration - you just connect your 4-th node to it. But if `cardano-tracer` is configured using `ConnectTo`, you should add path to 4-th socket in its configuration file and then restart `cardano-tracer` process.

## Network Magic

Expand Down
Loading