Skip to content

fix some typos #5708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix some typos #5708

wants to merge 1 commit into from

Conversation

cuinix
Copy link

@cuinix cuinix commented Mar 6, 2024

Description

fix some typos

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@cuinix cuinix requested review from a team as code owners March 6, 2024 07:25
Copy link

This PR is stale because it has been open 45 days with no activity.

@cuinix
Copy link
Author

cuinix commented May 15, 2025

Thanks. Modified. Please review again.

@carbolymer carbolymer enabled auto-merge May 19, 2025 08:23
Copy link

github-actions bot commented Jul 5, 2025

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jul 5, 2025
@carbolymer carbolymer removed the Stale label Jul 7, 2025
@carbolymer
Copy link
Contributor

@cuinix Could you sign your commits please? That's our requirement for all PRs.

Signed-off-by: cuinix <915115094@qq.com>
auto-merge was automatically disabled July 22, 2025 03:12

Head branch was pushed to by a user without write access

@cuinix
Copy link
Author

cuinix commented Jul 22, 2025

@cuinix Could you sign your commits please? That's our requirement for all PRs.

Thanks for your review!

Rebased and signed. Please review again when you have time. 😄

@carbolymer
Copy link
Contributor

carbolymer commented Jul 24, 2025

@cuinix Thanks! Could you rebase onto latest master? There are some conflicts which have to be resolved before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants