Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin cardano-node dependencies in cabal files. #4663

Open
coot opened this issue Nov 25, 2022 · 4 comments
Open

Pin cardano-node dependencies in cabal files. #4663

coot opened this issue Nov 25, 2022 · 4 comments

Comments

@coot
Copy link
Contributor

coot commented Nov 25, 2022

cardano-node dependencies should be pinned in *.cabal files rather than cabal.project file.

Note that people might use some packages independently of the others (thanks to CHaP), thus independent components should come with package bounds.

What I found so far is that we can pin network packages in cardano-api, which will be propagated to cardano-cli & cardano-node. But there are other nodes of the dependency graph which must be constraint, e.g. the trace-* packages, cardano-tracer package, etc.

We need to add upper bounds so that things don't suddenly break for downstream when a new version of some dependency is published to CHaP.

@andreabedini
Copy link
Contributor

Happy to help with this.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Dec 26, 2022
@dorin100 dorin100 added type: internal feature Non user-facing functionality user type: internal Created by an IOG employee labels Jan 9, 2023
@github-actions github-actions bot removed the Stale label Jan 10, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Feb 10, 2023
@nfrisby
Copy link
Contributor

nfrisby commented Aug 21, 2023

A brief Slack discussion today (about explicitly bounding eg the ledger packages) suggests that @Jimbo4350 is also interested in this.

@andreabedini andreabedini removed the Stale label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants