Add ascend env variables to dockerfile #3436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinminxi104
approved these changes
Apr 16, 2025
Collaborator
jinminxi104
left a comment
jinminxi104
left a comment
There was a problem hiding this comment.
This is an issue feedbacked from community.
(docker exec can not be run without -i)
grimoire
approved these changes
Apr 16, 2025
lvhan028
pushed a commit
that referenced
this pull request
Apr 17, 2025
Merged
lvhan028
pushed a commit
that referenced
this pull request
Apr 24, 2025
lvhan028
added a commit
that referenced
this pull request
May 4, 2025
* bump version to v0.8.0 * update supported models * update supported models * cherry-pick #3420 * modify ascend dockerfile to support direct run lmdeploy serve (#3436) * update supported models on ascend platform * update supported models --------- Co-authored-by: yaofengchen <67218893+yao-fengchen@users.noreply.github.com> Co-authored-by: Lantian Zhang <50076473+DoorKickers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
To support that docker exec -it container bash -c "lmdeploy serve ... " that doesn't load bashrc before run command.
Modification
Add ascend env variables to dockerfile, so the image itself contains ascend env variables. Don't need to load env variables in bashrc.
Checklist