Add state to Geoscanner return#806
Open
Da5h1n wants to merge 3 commits intoIntelligenceModding:dev/1.21.1from
Open
Add state to Geoscanner return#806Da5h1n wants to merge 3 commits intoIntelligenceModding:dev/1.21.1from
Da5h1n wants to merge 3 commits intoIntelligenceModding:dev/1.21.1from
Conversation
Collaborator
|
Code generally looks good, just need some formatting & caching. However, why is state needed in the result? What's the use example? |
SirEndii
requested changes
Feb 4, 2026
src/main/java/de/srendi/advancedperipherals/common/util/ScanUtils.java
Outdated
Show resolved
Hide resolved
Contributor
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
Member
|
Check build log for checkstyle issues and resolve them Also could you answer zyxkads question about the use case |
Author
Author
|
ive tested it both on turtles and as a peripheral and it works fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Geoscanners do not return Blockstate
What is the new behavior (if this is a feature change)?
Geoscanners can return Blockstate
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
No
Other information:
(my first time contributing on github, hope i done everything correctly)