-
-
Notifications
You must be signed in to change notification settings - Fork 89
Player rotate handle feature #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SirEndii
merged 47 commits into
IntelligenceModding:feat/keyboard
from
zyxkad:player-rotate-handle-feature
Mar 19, 2025
Merged
Player rotate handle feature #719
SirEndii
merged 47 commits into
IntelligenceModding:feat/keyboard
from
zyxkad:player-rotate-handle-feature
Mar 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abstract XDetector
abstract detectors
…ture smart glass patch
fix saddle turtle teleport between dimesions
peripheral_detach event will be trigger twice when ME network shutdown somehow
add CC Networking Cable p2p tunnel
should be eye position but not feet position
refactor fingerprint generator
allow equip distance detector in smartglasses
fix ClassNotFoundException when VS is not installed
…rly stage class loading resolve IntelligenceModding#715
fix crash when VS2 is not loaded
…ncedPeripherals into player-rotate-handle-feature
- fix keyboard container will keep reopen whenever holding G - rename glassesKeyPressed event to glasses_key_pressed - fix JEI will shown on keyboad container screen
zyxkad
commented
Mar 15, 2025
return; | ||
} | ||
// TODO: this for sure won't work on dedicated server | ||
if (!KeyBindings.GLASSES_HOTKEY_KEYBINDING.isDown()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just note this need some investigate for dedicated server.
SirEndii
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Bug feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
Kind of
Other information:
"keyboard_open"
fire when keyboard is actived"keyboard_closed"
fire when keyboard is deactived"player_mouse_move"
:deltaX, deltaY
"player_mouse_click"
:button
"player_mouse_up"
:button
"player_mouse_scroll"
:delta
isCapturingMouse
: whether the mouse event is forwarded as CC events.setCaptureMouse
: set if the mouse event should be forwarded as CC events when keyboard is active.