Skip to content

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Mar 15, 2025

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Bug feature

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    Kind of

  • Other information:

    • add events:
      • "keyboard_open" fire when keyboard is actived
      • "keyboard_closed" fire when keyboard is deactived
      • "player_mouse_move": deltaX, deltaY
      • "player_mouse_click": button
      • "player_mouse_up": button
      • "player_mouse_scroll": delta
    • add API on keyboard upgrade:
      • isCapturingMouse: whether the mouse event is forwarded as CC events.
      • setCaptureMouse: set if the mouse event should be forwarded as CC events when keyboard is active.

zyxkad and others added 30 commits January 16, 2025 23:28
abstract XDetector
fix saddle turtle teleport between dimesions
peripheral_detach event will be trigger twice when ME network shutdown somehow
should be eye position but not feet position
return;
}
// TODO: this for sure won't work on dedicated server
if (!KeyBindings.GLASSES_HOTKEY_KEYBINDING.isDown()) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just note this need some investigate for dedicated server.

@zyxkad zyxkad requested a review from SirEndii March 15, 2025 23:33
@zyxkad zyxkad linked an issue Mar 15, 2025 that may be closed by this pull request
Copy link
Member

@SirEndii SirEndii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SirEndii SirEndii merged commit 21e7aeb into IntelligenceModding:feat/keyboard Mar 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.8] Keyboard will not work after turtle moved
2 participants