Skip to content

fix crash when VS2 is not loaded #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2025
Merged

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Mar 14, 2025

  • move valkyrienskies stuff to a middle integration class to prevent early stage class loading
  • re-enable testing environement mods

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    N

  • Other information:
    I should never make PR using base branch name again

@zyxkad zyxkad added the 1.19x label Mar 14, 2025
@zyxkad zyxkad moved this to In review in 0.8/1.0 Backlog Mar 14, 2025
@zyxkad zyxkad added this to the 0.8r milestone Mar 14, 2025
@zyxkad zyxkad linked an issue Mar 14, 2025 that may be closed by this pull request
@zyxkad zyxkad removed this from 0.8/1.0 Backlog Mar 14, 2025
@zyxkad
Copy link
Collaborator Author

zyxkad commented Mar 15, 2025

really need this so I'll merge anyways

@zyxkad zyxkad merged commit d4b8b97 into IntelligenceModding:dev/0.8 Mar 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.8] Crash when valkyrienskies is not loaded
1 participant