Skip to content

Conversation

dogboy21
Copy link
Member

@dogboy21 dogboy21 commented Jun 1, 2024

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. This is not mandatory
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

Currently, the used gametest framework in #562 is based on the 1.19.x branch of CC: Tweaked.

  • What is the new behavior (if this is a feature change)?

Apparently some stuff has changed in the 1.20.x branch (for example support for client gametests) which this PR aims to backport to AP.

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)

All the old tests run without a problem

… the 1.20.x branch

This was mainly done to allow the execution of client tests
@SirEndii
Copy link
Member

SirEndii commented Jun 1, 2024

👁️

@SirEndii SirEndii added the 1.19x label Jun 1, 2024
@dogboy21 dogboy21 marked this pull request as ready for review June 1, 2024 23:42
@dogboy21 dogboy21 changed the title Backported changes from the CC: Tweaked Gametest framework present in… Backported changes from the CC: Tweaked Gametest framework present in 1.20.x Jun 1, 2024
@SirEndii SirEndii merged commit 321ab7e into IntelligenceModding:feat/tests Jun 2, 2024
@dogboy21 dogboy21 deleted the cctest-backport branch June 3, 2024 10:42
@dogboy21 dogboy21 restored the cctest-backport branch June 3, 2024 10:42
@dogboy21 dogboy21 deleted the cctest-backport branch June 3, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants