setBlockLight should define setBlockLight and resolve a few other minor inconsistencies #3365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or inconsistencies
SirYwell
reviewed
Nov 5, 2025
Member
SirYwell
left a comment
SirYwell
left a comment
There was a problem hiding this comment.
Mostly good, but please take another look at the usages of getBlockIS() regarding nullness if you're already at it.
...it-core/src/main/java/com/fastasyncworldedit/core/history/changeset/FaweStreamChangeSet.java
Show resolved
Hide resolved
PierreSchwang
approved these changes
Nov 23, 2025
NotMyFault
added
Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I addressed these in my larger Folia pull request, and because of rejection, I would like to forward these upstream separately. I am confident a lot of these issues aren't intentional. If any of these changes are deliberate, I'd be more than happy to revise!