-
-
Notifications
You must be signed in to change notification settings - Fork 313
fix: apply origin to sponge v3 schematics #2909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PierreSchwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work so far otherwise, I'd say.
You can cherrypick EngineHub/WorldEdit@cfd9eea into here as well, theoretically.
...ore/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/FastSchematicReaderV3.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/FastSchematicReaderV3.java
Show resolved
Hide resolved
...ore/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/FastSchematicReaderV3.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre Maurice Schwang <mail@pschwang.eu>
Co-authored-by: Pierre Maurice Schwang <mail@pschwang.eu>
|
I guess I'm okay with reading the whole tag, I don't expect the metadata to be that large. Could you please apply the correct PR template? It seems you deleted it |
@PierreSchwang I'm unable to find a way to retroactively apply a PR template (and copy-pasting from a different PR doesn't seem to format properly). |
I edited to my best - you may adjust |
|
@PierreSchwang all good from me unless you need anything else changed. |
...ore/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/FastSchematicReaderV3.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre Maurice Schwang <mail@pschwang.eu>
|
Thank you! |
Overview
Fixes #2864
Description