Skip to content

Conversation

@MidSpike
Copy link
Contributor

@MidSpike MidSpike commented Sep 11, 2024

Overview

Fixes #2864

Description

  • Applies the set origin in v3 schematics when loading using the fast implementation
  • Applies upstream fix for WorldEdit v3 reader EngineHub/WorldEdit@cfd9eea
### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@MidSpike MidSpike requested a review from a team as a code owner September 11, 2024 16:20
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Sep 11, 2024
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work so far otherwise, I'd say.

You can cherrypick EngineHub/WorldEdit@cfd9eea into here as well, theoretically.

MidSpike and others added 2 commits September 11, 2024 17:58
Co-authored-by: Pierre Maurice Schwang <mail@pschwang.eu>
Co-authored-by: Pierre Maurice Schwang <mail@pschwang.eu>
@PierreSchwang PierreSchwang changed the title fix(#2864) fix: apply origin to sponge v3 schematics Sep 12, 2024
@PierreSchwang
Copy link
Member

I guess I'm okay with reading the whole tag, I don't expect the metadata to be that large. Could you please apply the correct PR template? It seems you deleted it

@MidSpike
Copy link
Contributor Author

I guess I'm okay with reading the whole tag, I don't expect the metadata to be that large. Could you please apply the correct PR template? It seems you deleted it

@PierreSchwang I'm unable to find a way to retroactively apply a PR template (and copy-pasting from a different PR doesn't seem to format properly).

@PierreSchwang
Copy link
Member

I guess I'm okay with reading the whole tag, I don't expect the metadata to be that large. Could you please apply the correct PR template? It seems you deleted it

@PierreSchwang I'm unable to find a way to retroactively apply a PR template (and copy-pasting from a different PR doesn't seem to format properly).

I edited to my best - you may adjust

@MidSpike
Copy link
Contributor Author

@PierreSchwang all good from me unless you need anything else changed.

Co-authored-by: Pierre Maurice Schwang <mail@pschwang.eu>
@PierreSchwang PierreSchwang requested a review from a team September 16, 2024 23:34
@PierreSchwang
Copy link
Member

Thank you!

@PierreSchwang PierreSchwang merged commit 8e1922d into IntellectualSites:main Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schematics dont remember their positions

3 participants