This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Remove _remove_unneeded_phis() #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was removed for release0.50 in commit e566755. Due to some merging error this commit was not applied to our main branch.
|
@PokhodenkoSA : I have no idea why this was not deleted from 50.0 to 51. I can not think of any reason. |
Thank you @reazulhoque. I think we do not need this code. |
|
@reazulhoque If you do not know then we do not need this code. |
|
I think so. |
|
As we discussed with @Hardcode84 there is no info about this function impact. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was removed for release0.50 in commit e566755.
Due to some merging error this commit was not applied to our
main branch.
@reazulhoque if you have some info about this function and why it was no deleted, please, inform me.
@Hardcode84 this function could influence on some issues we could have from Numba 0.50. This function was removed in official Numba 0.50 but was in our code and was in our package. Possibly, you have faced some problems related to this. Please, inform me.
Closes #51.