This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Semantics "with dppl_context" #40
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reazulhoque
reviewed
Sep 9, 2020
| @@ -335,6 +336,8 @@ def dispatcher_factory(func_ir, objectmode=False, **kwargs): | |||
| myflags.force_pyobject = True | |||
| myflags.no_cpython_wrapper = False | |||
| cls = ObjModeLiftedWith | |||
| elif dppl_mode: | |||
| cls = DPPLLiftedWith | |||
There was a problem hiding this comment.
This is necessary to create a dispatcher specifically for lifted code with new semantics. This is for now an intermediate solution, in the future it will be necessary to rewrite it so as not to change the numba files.
reazulhoque
reviewed
Sep 9, 2020
| from numba.core.cpu_options import ParallelOptions | ||
|
|
||
|
|
||
| class _DPPLContextType(WithContext): |
There was a problem hiding this comment.
Can you please explain what this functions are doing?
There was a problem hiding this comment.
This is a class that creates a separate dispatcher for the lifted code with our semantics. This is needed to run the code with the 'offload': True option and our pipeline
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.