Rename dppl to dppy #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PokhodenkoSA
suggested changes
Dec 4, 2020
|
I'll tested it with IntelPython/dpctl#201 Ran 140 tests in 28.973s dpctl 0.3.8+100.gba65df7 pypi_0 pypi |
diptorupd
approved these changes
Dec 4, 2020
numba_dppy/__init__.py
Outdated
| @@ -509,11 +509,11 @@ def main(): | |||
| if dppy_present: | |||
| from .device_init import * | |||
| else: | |||
| raise ImportError("Importing dppl failed") | |||
| raise ImportError("Importing dppy failed") | |||
There was a problem hiding this comment.
numba-dppy instead of dppy. Our extension package is called numba-dppy.
|
@PokhodenkoSA I have merged master and made couple of changes to let numba-dppy build with dpctl/master. For CI, do we need to tag a new RC candidate for dpctl and merge it to gold/2021? |
PokhodenkoSA
reviewed
Dec 5, 2020
conda-recipe/meta.yaml
Outdated
| @@ -23,6 +23,7 @@ requirements: | |||
| run: | |||
| - python | |||
| - numba >=0.51 | |||
| - cffi | |||
There was a problem hiding this comment.
Suggested change
| - cffi |
PokhodenkoSA
reviewed
Dec 5, 2020
setup.py
Outdated
| @@ -38,6 +38,7 @@ def get_ext_modules(): | |||
| build_requires = ["cython"] | |||
| install_requires = [ | |||
| "numba", | |||
| "cffi", | |||
There was a problem hiding this comment.
Suggested change
| "cffi", |
PokhodenkoSA
reviewed
Dec 5, 2020
Comment on lines
+8
to
+9
| # from numba_dppy.tests.dppy import * | ||
|
|
PokhodenkoSA
suggested changes
Dec 5, 2020
PokhodenkoSA
approved these changes
Dec 7, 2020
DrTodd13
pushed a commit
that referenced
this pull request
Dec 10, 2020
Co-authored-by: etotmeni <elena.totmenina@intel.com> Co-authored-by: Diptorup Deb <diptorup.deb@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the issue #8
Files in which it was not possible to rename, due to connection with dpCtl:
Locally tested:
Ran 140 tests in 28.366s
OK (skipped=26, expected failures=1)