Skip to content

Temporary disable failing tests for NaN input passed to dpnp.linalg.cond #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

Temporary disable failing tests for NaN input passed to dpnp.linalg.cond #2454

merged 3 commits into from
May 15, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 15, 2025 •
edited
Loading

The PR mutes the tests/test_linalg.py::TestCond::test_nan tests temporary on Windows to unblock the internal CI.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this May 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_22 ran successfully.
Passed: 1229
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented May 15, 2025 •
edited
Loading

Coverage Status

coverage: 71.711%. remained the same
when pulling e91fc7a on disable-failing-cond-tests-on-windows
into 8cef740 on master.

@antonwolfy antonwolfy merged commit 78179a2 into master May 15, 2025
68 checks passed
@antonwolfy antonwolfy deleted the disable-failing-cond-tests-on-windows branch May 15, 2025 22:19
github-actions bot added a commit that referenced this pull request May 15, 2025
@github-actions
Temporary disable failing tests for NaN input passed to `dpnp.linalg.…
057e66b 
…cond` (#2454)

The PR mutes the `tests/test_linalg.py::TestCond::test_nan` tests
temporary on Windows to unblock the internal CI. 78179a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana