Apply w/a for expected result in spacing test only on non-Intel NumPy #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev,
vtavana and
ndgrigorian
as code owners
antonwolfy
force-pushed
the
resolve-issue-with-spacing-tests
branch
2 times, most recently
from
5a85c7b to
d2c672e
Compare
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_22 ran successfully. |
antonwolfy
force-pushed
the
resolve-issue-with-spacing-tests
branch
from
fdf4e21 to
a77433a
Compare
antonwolfy
force-pushed
the
resolve-issue-with-spacing-tests
branch
2 times, most recently
from
8dc2523 to
514947a
Compare
antonwolfy
force-pushed
the
resolve-issue-with-spacing-tests
branch
from
514947a to
1871ca3
Compare
vtavana
approved these changes
May 15, 2025
github-actions bot
added a commit
that referenced
this pull request
May 15, 2025
…#2453) The stock NumPy returns incorrect result for `numpy.spacing(-0.0)`, while Intel NumPy returns the expected one (the same as dpnp also). It might be the case when dpnp test is running with the stock NumPy. Thus the PR add a conditional check to update expected result in `TestSpacing::test_zeros` in case when non-Intel NumPy is used. Previously the same logic was based on NumPy version, assuming Intel NumPy has always `version < "2.0.0"`, but it is not the case anymore. 8cef740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stock NumPy returns incorrect result for
numpy.spacing(-0.0), while Intel NumPy returns the expected one (the same as dpnp also).It might be the case when dpnp test is running with the stock NumPy. Thus the PR add a conditional check to update expected result in
TestSpacing::test_zerosin case when non-Intel NumPy is used.Previously the same logic was based on NumPy version, assuming Intel NumPy has always
version < "2.0.0", but it is not the case anymore.