Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with asynchronous execution in dpnp.fft module #2067

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Fix an issue with asynchronous execution in dpnp.fft module #2067

merged 4 commits into from
Sep 20, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Sep 19, 2024 •
edited
Loading

In this PR, an issue regarding asynchronous execution of dpnp.fft module is resolved. In the process of padding the input arrays, dependent event list (dep_evs) was obtained before creating the new zero array which by itself add a new dependent event to dep_evs list. So, we need to get dep_evs after calling dpnp.zeros.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review September 20, 2024 01:27
antonwolfy
antonwolfy approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for catching and resolving that.

@vtavana vtavana merged commit 81144e8 into master Sep 20, 2024
41 of 45 checks passed
@vtavana vtavana deleted the fix-FFT-fails branch September 20, 2024 12:32
vtavana added a commit that referenced this pull request Sep 20, 2024
@vtavana
Fix an issue with asynchronous execution in dpnp.fft module (#2067)
2c6b620 
* get the final list of dependent events just before using it

* update changelog.md
@vtavana vtavana mentioned this pull request Sep 20, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Sep 20, 2024
@github-actions
Fix an issue with asynchronous execution in dpnp.fft module (#2067)
2eec451 
* get the final list of dependent events just before using it

* update changelog.md 81144e8
github-actions bot added a commit that referenced this pull request Sep 20, 2024
@github-actions
backport-gh-2067 69a3b6a
37aad80
antonwolfy pushed a commit that referenced this pull request Sep 21, 2024
@vtavana
Fix an issue with asynchronous execution in dpnp.fft module (#2067) (…
dd2ff5d 
…#2070)

* get the final list of dependent events just before using it

* update changelog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy