-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dpnp.clip()
with Numpy 2.0
#2048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy,
npolina4 and
vtavana
as code owners
September 16, 2024 12:16
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Sep 24, 2024
antonwolfy
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vlad-perevezentsev
Please update changelog also.
antonwolfy
approved these changes
Sep 26, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 26, 2024
* Update dpnp.clip to align with numpy 2.0 * Update cupy tests * Compliance of dpnp.clip() with Array API * Update CHANGELOG.md 5a368d9
vlad-perevezentsev
added a commit
that referenced
this pull request
Sep 27, 2024
* Update dpnp.clip to align with numpy 2.0 * Update cupy tests * Compliance of dpnp.clip() with Array API * Update CHANGELOG.md
6 tasks
vlad-perevezentsev
added a commit
that referenced
this pull request
Sep 27, 2024
* Update dpnp.clip to align with numpy 2.0 * Update cupy tests * Compliance of dpnp.clip() with Array API * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests using
a_min
anda_max
arguments ofdpnp.clip()
asNone
by default to align with Numpy 2.0 instead of usingnp.NoValue
as in Numpy=2.0 and also updates cupy tests for this function