Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation of dpnp.fix function #1971

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Add implementation of dpnp.fix function #1971

merged 5 commits into from
Aug 12, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 5, 2024 •
edited by vtavana
Loading

The PR proposes to add implementation of dpnp.fix function.

The new dedicated _fix function is added to _ufunc_impl pybind11 extension.
All the required tests are implement to cover the function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull/1971/index.html

@antonwolfy antonwolfy marked this pull request as ready for review August 5, 2024 21:24
vtavana
vtavana approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
antonwolfy and others added 2 commits August 11, 2024 06:47
@antonwolfy @vtavana
Update dpnp/dpnp_iface_mathematical.py
646c3d7 
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
@antonwolfy
Merge branch 'master' into impl-fix
d2c80ed
@antonwolfy antonwolfy merged commit e4acd3e into master Aug 12, 2024
32 of 41 checks passed
@antonwolfy antonwolfy deleted the impl-fix branch August 12, 2024 07:30
github-actions bot added a commit that referenced this pull request Aug 12, 2024
@github-actions
Add implementation of dpnp.fix function (#1971)
f5dca3d 
* Implement dpnp.fix()

* Add tests to cover function

* Update dpnp/dpnp_iface_mathematical.py

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> e4acd3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana