Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with dpt.where which support scalar as input #1932

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Align with dpt.where which support scalar as input #1932

merged 3 commits into from
Jul 23, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 16, 2024 •
edited
Loading

The PR aligns with the recent change in dpctl (dpctl-1719) where support for Python scalars added to dpt.where function.
This way dpnp can fully rely on dpctl implementation when it receives the scalars.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review July 23, 2024 14:01
vtavana
vtavana approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 9a29427 into master Jul 23, 2024
38 of 45 checks passed
@antonwolfy antonwolfy deleted the support-scalars-in-where branch July 23, 2024 15:01
github-actions bot added a commit that referenced this pull request Jul 23, 2024
@github-actions
Align with dpt.where which support scalar as input (#1932)
2511791 
* Align with dpt.where() which support scalar as input

* Removed unused import of get_usm_allocations 9a29427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana