-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support usm_ndarray batched input for dpnp.linalg #1880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @vlad-perevezentsev!
antonwolfy
reviewed
Jun 13, 2024
antonwolfy
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vlad-perevezentsev
github-actions bot
added a commit
that referenced
this pull request
Jun 17, 2024
* Add usm_ndarray input support for linalg * Add test_usm_ndarray_input_batch to test_linalg.py * Add usm_ndarray input support for dpnp_iface_linearalgebra * Add test_usm_ndarray_linearalgebra_batch to test_linalg.py * Apply comments --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 96a2e41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1867 many functions from dpnp.linalg are implemented wrongly for usm_ndarray batched input.
The implementations often call a method that does not support usm_ndarray which raises an error.
This PR suggests fixing this and using dpnp functions instead of ndarray methods and adding a new test to cover these cases