Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support usm_ndarray batched input for dpnp.linalg #1880

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Support usm_ndarray batched input for dpnp.linalg #1880

merged 7 commits into from
Jun 17, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

As noted in #1867 many functions from dpnp.linalg are implemented wrongly for usm_ndarray batched input.
The implementations often call a method that does not support usm_ndarray which raises an error.

This PR suggests fixing this and using dpnp functions instead of ndarray methods and adding a new test to cover these cases

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vlad-perevezentsev!

tests/test_linalg.py Outdated Show resolved Hide resolved
tests/test_linalg.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit 96a2e41 into master Jun 17, 2024
48 of 56 checks passed
@antonwolfy antonwolfy deleted the support_usm_ndarray_input_linalg_funcs branch June 17, 2024 12:34
github-actions bot added a commit that referenced this pull request Jun 17, 2024
@github-actions
Support usm_ndarray batched input for dpnp.linalg (#1880)
68859a2 
* Add usm_ndarray input support for linalg

* Add test_usm_ndarray_input_batch to test_linalg.py

* Add usm_ndarray input support for dpnp_iface_linearalgebra

* Add test_usm_ndarray_linearalgebra_batch to test_linalg.py

* Apply comments

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 96a2e41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @antonwolfy @vtavana