Implement gesv_batch via gesv call #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Jun 12, 2024
antonwolfy
reviewed
Jul 26, 2024
antonwolfy
reviewed
Jul 31, 2024
antonwolfy
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
It's great improvement of dpnp.solve. Thank you @vlad-perevezentsev, LGTM!
github-actions bot
added a commit
that referenced
this pull request
Aug 8, 2024
* First working version with transpose and C contig * Second working version with moveaxis, transpose and F contig * Add more shape checks * Pass sycl::queue by reference for gesv/gesv_batch * Update _batched_solve implementation * Remove old impl in _batched_solve * Use py::gil_scoped_release before gesv call * Move gesv_batch to gesv_batch.cpp * Improve gesv_batch with independent linear streams * Extend checks for gesv/gesv_batch * Add common_gesv_checks * Release GIL in gesv_batch_impl * Remove host_task_events from gesv * Use check_zeros_shape in gesv and gesv_batch * Add additional checks for gesv_impl * Move alloc_scratchpad to common_helpers.hpp * Use helper::alloc_scratchpad in gesv_batch_impl * Remove current_scratch_gesv check * Remove lda, ldb pass to gesv_batch_impl, gesv_impl * Use const and constexpr in gesv/gesv_batch * Use dpnp.reshape in _batched_solve * Implement alloc_ipiv in common_helpers.hpp * Add gesv_common_utils.hpp * Implement handle_lapack_exc function * Use try/catch for scratchpad/ipiv allocation * Update alloc_scratchpad/alloc_ipiv * gesv_scratchpad_size can be 0 * Implement help functions alloc_ipiv/alloc_scratchpad * Reuse alloc_scratchpad/ipiv in batch versions 1e5ba88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests adding
gesv_batchimplementation as a separate function and provide iteration of the batch array within it to avoid allocation of each 2D array before callinggesvto improve performance and avoid serialization of all host tasks in the queue in MKL call;Performance of
dpnp.solveon Iris Xe