-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RuntimeError raising in dpnp.linalg.solve()
#1763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Apr 2, 2024
vlad-perevezentsev
changed the title
Update dpnp.linalg.solve() with w/a for SAT-6701
Fix RuntimeError raising in Apr 3, 2024
dpnp.linalg.solve()
antonwolfy
approved these changes
Apr 7, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 8, 2024
* Correct parameter calculation for gesv * Use getrf and getrs MKL funcs in dpnp_solve for 2d array * Add test to cover SAT-6701 case * Extend test_solve in test_sycl_queue.py * Address remarks * Support as F-contiguous for _getrs --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 2a2cdfa
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Apr 8, 2024
* Correct parameter calculation for gesv * Use getrf and getrs MKL funcs in dpnp_solve for 2d array * Add test to cover SAT-6701 case * Extend test_solve in test_sycl_queue.py * Address remarks * Support as F-contiguous for _getrs --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 2a2cdfa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests using
oneapi::mkl::lapack::getrf
andoneapi::mkl::lapack::getrs
call instead ofoneapi::mkl::lapack::gesv
in implementation ofdpnp.linalg.solve()
as a workaround for MKLD-17226 and allows to handle cases wherenrhs > n
for a_shape (n x n) and b_shape (n x nrhs).Example output with RuntimeError
Output after changes