return a view for dpnp.ndarray.real and dpnp.ndarray.imag
#1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
force-pushed
the
return_view_of_real_imag
branch
from
10bef74
to
40d5de4
Compare
antonwolfy
approved these changes
Feb 18, 2024
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Feb 19, 2024
…ython#1719) * return a view for dpnp.ndarray.real/imag * return self for real numbers * update real/imag/conj test * fix dtype in test_conj_out 3324da4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
dpnp.ndarray.realanddpnp.ndarray.imagare modified to return a view of the input array using theirdpctlcounterpart. Note thatdpnp.realanddpnp.imagreturn a copy consistent withdpctlbehavior.Also, new tests are added to check the correctness of writable flag in different scenarios, due to new changes in dpctl #1527.