Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sparse and copy arguments for dpnp.meshgrid function #1675

Merged
merged 7 commits into from
Feb 3, 2024
Merged

Implement sparse and copy arguments for dpnp.meshgrid function #1675

merged 7 commits into from
Feb 3, 2024

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Jan 31, 2024 •
edited by antonwolfy
Loading

Implement sparse and copy arguments for dpnp.mesgrid function

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

antonwolfy
antonwolfy reviewed Feb 1, 2024
View reviewed changes
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4

@antonwolfy antonwolfy merged commit 7c4b39a into master Feb 3, 2024
44 of 45 checks passed
@antonwolfy antonwolfy deleted the meshgrid_func branch February 3, 2024 14:29
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Feb 3, 2024
@github-actions @antonwolfy
Implement sparse and copy arguments for dpnp.mesgrid function (IntelP…
ee0a8bc 
…ython#1675)

* Implement sparse and copy arguments for dpnp.mesgrid function

* address comments

* Removed limitation block from th description

* added tests

---------

Co-authored-by: Anton Volkov <antonwolfy@gmail.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 7c4b39a
@antonwolfy antonwolfy changed the title Implement sparse and copy arguments for dpnp.mesgrid function Implement sparse and copy arguments for dpnp.meshgrid function Feb 10, 2024
@antonwolfy antonwolfy mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy