Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for newer version of DPC++ compiler #1664

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Allow for newer version of DPC++ compiler #1664

merged 2 commits into from
Jan 23, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 23, 2024 •
edited
Loading

The PR modifies meta.yaml to disallow 2024.0.1 and 2024.0.2 but allow for newer DPC++ compiler versions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit e404fa6 into master Jan 23, 2024
40 of 45 checks passed
@antonwolfy antonwolfy deleted the allow_newer_compiler branch January 23, 2024 15:08
github-actions bot added a commit that referenced this pull request Jan 23, 2024
@github-actions
Allow for newer version of DPC++ compiler (#1664)
726f4fe 
* Allow for newer version of DPC++ compiler

* Stepped dpctl versions in all yaml files e404fa6
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Jan 23, 2024
@github-actions
Allow for newer version of DPC++ compiler (IntelPython#1664)
c3db61d 
* Allow for newer version of DPC++ compiler

* Stepped dpctl versions in all yaml files e404fa6
@antonwolfy antonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana