Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve compilation warnings #1651

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Resolve compilation warnings #1651

merged 2 commits into from
Jan 9, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 8, 2024

The PR proposes to resolve compilation warnings with the latest DPC++ towards 2024.1 release.

The warning appeared since the compiler enabled -Wvla-extension option for C++ by default and so the users are made aware of the extension, especially given the security implications around stack overflows with VLAs that can be mitigated by heap allocations through C++ containers.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Jan 9, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@antonwolfy antonwolfy marked this pull request as ready for review January 9, 2024 14:31
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 5b25163 into master Jan 9, 2024
45 checks passed
@antonwolfy antonwolfy deleted the fix_cmplr_warnings branch January 9, 2024 17:06
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Jan 9, 2024
* Resolved compilation warnings

* Explicit instantiation of dpnp_max_c and dpnp_min_c 5b25163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants