Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement of dpnp.clip() #1645

Merged
merged 5 commits into from
Dec 16, 2023
Merged

Implement of dpnp.clip() #1645

merged 5 commits into from
Dec 16, 2023

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Dec 15, 2023 •
edited by antonwolfy
Loading

dpnp.clip is implemented using dpctl.tensor.clip.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Dec 15, 2023
View reviewed changes
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
@antonwolfy antonwolfy merged commit d9c1ca1 into master Dec 16, 2023
39 of 45 checks passed
@antonwolfy antonwolfy deleted the impl_clip branch December 16, 2023 15:01
github-actions bot added a commit that referenced this pull request Dec 16, 2023
@github-actions @antonwolfy
Implement of dpnp.clip() (#1645)
fdb590e 
* Implement of dpnp.clip()

* address comments

* Increased tests coverage

---------

Co-authored-by: Anton Volkov <antonwolfy@gmail.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> d9c1ca1
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
@antonwolfy antonwolfy mentioned this pull request May 31, 2024
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy