Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align arguments of dpnp.true_divide with dpnp.divide #1641

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Align arguments of dpnp.true_divide with dpnp.divide #1641

merged 2 commits into from
Dec 12, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 11, 2023 •
edited
Loading

In NumPy true_divide is alias on divide function.
The PR proposes to implement exactly the same behavior. It will allow to have exactly the same arguments for true_divide as divide has.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 11, 2023
vtavana
vtavana approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit e2188ed into master Dec 12, 2023
41 of 45 checks passed
@antonwolfy antonwolfy deleted the align_true_divide branch December 12, 2023 20:17
github-actions bot added a commit that referenced this pull request Dec 12, 2023
@github-actions
Align arguments of true_divide with divide (#1641) e2188ed
9193b9d
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana