Skip to content

Added support dtype and out arguments for dpnp.concatenate and dpnp.stack functions #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2023
Merged

Added support dtype and out arguments for dpnp.concatenate and dpnp.stack functions #1608

merged 4 commits into from
Nov 3, 2023

Conversation

npolina4
Copy link
Contributor

Added support dtype and out arguments for dpnp.concatenate and dpnp.stack functions.
Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@npolina4 npolina4 requested a review from antonwolfy October 25, 2023 08:13
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Oct 25, 2023
View reviewed changes
antonwolfy
antonwolfy approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4 LGTM!

@antonwolfy antonwolfy merged commit a173ccc into master Nov 3, 2023
@antonwolfy antonwolfy deleted the update_concat_stack branch November 3, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy