Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement of dpnp.linalg.slogdet() #1607

Merged
merged 66 commits into from
Jan 12, 2024
Merged

Implement of dpnp.linalg.slogdet() #1607

merged 66 commits into from
Jan 12, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Oct 23, 2023 •
edited
Loading

This PR

  1. adds a function dpnp.linalg.slogdet() to get sign and logarithm of the determinant of an input array and a private function dpnp.linalg._lu_factor() to compute the LU factorization of a general n x n
    input matrix using oneapi::mkl::lapack::getrf and oneapi::mkl::lapack::getrf_batch.
    The implementation is written as an extension of pybind11 over the necessary LAPACK functions.

  2. updates the implementation of the dpnp.linalg.det() function using dpnp.linalg.slogdet()

  3. adds support the complex data type for dpnp.diagonal() function

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Oct 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vlad-perevezentsev vlad-perevezentsev changed the title Implement of dpnp.linalg._lu_factor() Implement of dpnp.linalg.slogdet() Oct 31, 2023
@vlad-perevezentsev
Merge master into impl_lu_factor
2419eba
@vlad-perevezentsev
A small update _lu_factor func
a8789e4
@vlad-perevezentsev
Remove w/a for dpnp.count_nonzero in slogdet
59642f6
@vlad-perevezentsev
getrf returns pair of events and uses dpctl.utils.keep_args_alive
db45555
@vlad-perevezentsev
Update dpnp.linalg.det using slogdet
0350d86
@vlad-perevezentsev
Add new cupy tests for dpnp.linalg.det
6c20deb
@vlad-perevezentsev
Merge master into impl_lu_factor
b17802d
@vlad-perevezentsev
Add ipiv_vecs and dev_info_vecs in _lu_factor for the batch case
3359c05
@vlad-perevezentsev
Skip test_det on CPU due to bug in MKL
1a91385
@vlad-perevezentsev
Small update of cupy tests in test_norms.py
b860790
@vlad-perevezentsev
Add support of complex dtype for dpnp.diagonal and update test_diagonal
37d476b
@vlad-perevezentsev
lu_factor func returns the result of LU decomposition as c-contiguous…
2e8b4fe 
… and add explanatory comments
@vlad-perevezentsev
Add getrf_batch MKL extension
3849d92
@vlad-perevezentsev
Update docstring for slogdet
cd282a3
@vlad-perevezentsev
Add more tests
771605f
@vlad-perevezentsev
Merge master into impl_lu_factor
35de575
@vlad-perevezentsev
Remove accidentally added file
cde627d
@vlad-perevezentsev
Modify sign parameter calculation
694870b
@vlad-perevezentsev
Add _real_type func
1f9b6fa
@vlad-perevezentsev
Add test_det in test_usm_type
7e12063
@vlad-perevezentsev
Add more checks in getrf and getf_batch functions
0e82258
@vlad-perevezentsev
Improve error handler in getrf_impl
3a6e5ce
@vlad-perevezentsev
Improve error handler in getrf_batch_impl
6700fce
@vlad-perevezentsev
dev_info is allocated as zeros
644485b
@vlad-perevezentsev
Remove skipif for singular tests
5015e15
@vlad-perevezentsev
Implement _lu_factor logic with dev_info as a python list
68c436e
@vlad-perevezentsev
Update getrf_rf error handler with mkl_lapack::batch_error
030a083
@vlad-perevezentsev
Remove passing n parameter to _getrf
579b4e5
@vlad-perevezentsev
Add a new test_slogdet_singular_matrix_3D test
acd04b7
@vlad-perevezentsev
Merge remote-tracking branch 'origin/master' into impl_lu_factor
0fe0bf1
@vlad-perevezentsev
Update tests for dpnp.linalg.det
f0cc4d3
@vlad-perevezentsev
Merge master into impl_lu_factor
8896aab
@vlad-perevezentsev
Use is_exception_caught flag in getrf and getrf_batch error handler
c9b7c3b
@vlad-perevezentsev
Update gesv error handler
a3873cd
@vlad-perevezentsev
Reshape results after calling getrf_batch
9652797
@vlad-perevezentsev
Add a new dpnp.linalg.det impl and refresh dpnp_utils_linalg
cef4690
@vlad-perevezentsev
Remove Limitations from dpnp_det and dpnp_slogdet docstings
67681bf
antonwolfy
antonwolfy reviewed Jan 9, 2024
View reviewed changes
dpnp/backend/extensions/lapack/getrf.cpp Show resolved Hide resolved
dpnp/backend/extensions/lapack/getrf.cpp Show resolved Hide resolved
dpnp/backend/extensions/lapack/getrf.cpp Show resolved Hide resolved
dpnp/linalg/dpnp_utils_linalg.py Show resolved Hide resolved
dpnp/linalg/dpnp_utils_linalg.py Show resolved Hide resolved
dpnp/linalg/dpnp_utils_linalg.py Outdated Show resolved Hide resolved
tests/test_linalg.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev LGTM!

@antonwolfy antonwolfy merged commit 7e54eb8 into master Jan 12, 2024
41 of 45 checks passed
@antonwolfy antonwolfy deleted the impl_lu_factor branch January 12, 2024 19:00
@antonwolfy antonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy