Skip to content

fix dpnp.linalg.qr and dpnp.linalg.det functions #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2023
Merged

fix dpnp.linalg.qr and dpnp.linalg.det functions #1592

merged 4 commits into from
Oct 16, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 12, 2023 •
edited
Loading

dpnp.linalg.qr is updated to take care of the cases where input array is not 2-D.
dpnp.linalg.det is updated to take care of the cases where input array is an empty array.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review October 12, 2023 21:09
@vtavana vtavana requested a review from antonwolfy October 12, 2023 21:10
antonwolfy
antonwolfy reviewed Oct 13, 2023
View reviewed changes
@vtavana vtavana changed the title fix qr function fix dpnp.linalg.qr and dpnp.linalg.det functions Oct 13, 2023
antonwolfy
antonwolfy approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for catching and resolving the issues.

@antonwolfy antonwolfy merged commit 3b5a588 into master Oct 16, 2023
@antonwolfy antonwolfy deleted the fix_qr branch October 16, 2023 17:27
vtavana added a commit that referenced this pull request Oct 16, 2023
@vtavana
fix dpnp.linalg.qr and dpnp.linalg.det functions (#1592)
e820b12 
* modifying dpnp.linalg.qr function

* modifying dpnp.linalg.det function

* fix pre-commit
@vtavana vtavana mentioned this pull request Oct 16, 2023
Merged
6 tasks
antonwolfy added a commit that referenced this pull request Oct 16, 2023
@vtavana @antonwolfy
Fuzz testing fixes (#1596)
f6d175b 
* fix cholesky for 0-D array (#1584)

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>

* fix `dpnp.linalg.qr` and `dpnp.linalg.det` functions (#1592)

* modifying dpnp.linalg.qr function

* modifying dpnp.linalg.det function

* fix pre-commit

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy