Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flipping functions #1543

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Added flipping functions #1543

merged 3 commits into from
Aug 28, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 28, 2023 •
edited
Loading

The PR proposes to implement dpnp.flip, dpnp.fliplr and dpnp.flipud functions.
The dpnp.flip is leveraging on dpctl.tensor implementation of flip, while others are implemented through indexing functionality.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana reviewed Aug 28, 2023
View reviewed changes
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/test_flipping.py Outdated Show resolved Hide resolved
tests/test_flipping.py Outdated Show resolved Hide resolved
vtavana
vtavana approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy

@antonwolfy antonwolfy merged commit b694d87 into master Aug 28, 2023
21 checks passed
@antonwolfy antonwolfy deleted the add_flipping_funcs branch August 28, 2023 23:17
antonwolfy added a commit that referenced this pull request Sep 12, 2023
@antonwolfy
Added gh-1543
de518bf
antonwolfy added a commit that referenced this pull request Sep 12, 2023
@antonwolfy
Update change log due to 2024.0 release (#1555)
4813810 
* Updated change log towards 2024.0 release

* Added gh-1543

* Corrected description for gh-1545
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana