Skip to content

Reduce scope of skipping tests on device without fp64 aspect #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 17, 2023

Since #1515 is closed, the tests relating to dpnp.reminder and dpnp.mod can be unmuted, since they are not failing anymore on a device without fp64 aspect.
The TR also removed skipped tests for another already elementwise function leveraged from dpctl, such as dpnp.add, dpnp.divide, dpnp.subtract and some others.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana
Copy link
Collaborator

vtavana commented Aug 17, 2023

The following cases fail

  • FAILED tests/test_umath.py::test_umaths[('cos', 'd')0] - ValueError: Device Intel(R) Graphics [0x46a8] does not provide native support for double-precision floating point type.
  • FAILED tests/test_umath.py::test_umaths[('cos', 'd')1] - ValueError: Device Intel(R) Graphics [0x46a8] does not provide native support for double-precision floating point type.
  • FAILED tests/test_umath.py::test_umaths[('sin', 'd')0] - ValueError: Device Intel(R) Graphics [0x46a8] does not provide native support for double-precision floating point type.
  • FAILED tests/test_umath.py::test_umaths[('sin', 'd')1] - ValueError: Device Intel(R) Graphics [0x46a8] does not provide native support for double-precision floating point type.

Inside skipped_tests_gpu_no_fp64.tbl
line 498

  • tests/test_umath.py::test_umaths[('cos', 'd')]
    should be replaced with
  • tests/test_umath.py::test_umaths[('cos', 'd')0]
  • tests/test_umath.py::test_umaths[('cos', 'd')1]

and similarly line 503

  • tests/test_umath.py::test_umaths[('sin', 'd')]
    should be replaced with
  • tests/test_umath.py::test_umaths[('sin', 'd')0]
  • tests/test_umath.py::test_umaths[('sin', 'd')1]

@vtavana vtavana closed this Aug 17, 2023
@antonwolfy antonwolfy reopened this Aug 17, 2023
@antonwolfy
Copy link
Contributor Author

The following cases fail

  • FAILED tests/test_umath.py::test_umaths[('cos', 'd')0] - ValueError: Device Intel(R) Graphics [0x46a8] does not provide native support for double-precision floating point type.
  • FAILED tests/test_umath.py::test_umaths[('cos', 'd')1] - ValueError: Device Intel(R) Graphics [0x46a8] does not provide native support for double-precision floating point type.
  • FAILED tests/test_umath.py::test_umaths[('sin', 'd')0] - ValueError: Device Intel(R) Graphics [0x46a8] does not provide native support for double-precision floating point type.
  • FAILED tests/test_umath.py::test_umaths[('sin', 'd')1] - ValueError: Device Intel(R) Graphics [0x46a8] does not provide native support for double-precision floating point type.

Inside skipped_tests_gpu_no_fp64.tbl line 498

  • tests/test_umath.py::test_umaths[('cos', 'd')]
    should be replaced with
  • tests/test_umath.py::test_umaths[('cos', 'd')0]
  • tests/test_umath.py::test_umaths[('cos', 'd')1]

and similarly line 503

  • tests/test_umath.py::test_umaths[('sin', 'd')]
    should be replaced with
  • tests/test_umath.py::test_umaths[('sin', 'd')0]
  • tests/test_umath.py::test_umaths[('sin', 'd')1]

The test_umaths test generated duplicated pairs to loop over. The test is updated to apply the comment.

Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy

@antonwolfy antonwolfy merged commit 2a43630 into master Aug 18, 2023
@antonwolfy antonwolfy deleted the reduce_skip_tests_scope branch August 18, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants