Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_dpctl_round_func_in_dpnp #1520

Merged
merged 5 commits into from
Aug 24, 2023
Merged

use_dpctl_round_func_in_dpnp #1520

merged 5 commits into from
Aug 24, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 11, 2023 •
edited
Loading

The PR changes the implementation of dpnp.round and its alias dpnp.around. These functions now invoke oneapi::mkl::vm::rint from pybind11 extension of OneMKL VM if possible or uses dpctl.tensor.round implementation if not.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana changed the base branch from use_dpctl_rounding_funcs to master August 11, 2023 22:45
@vtavana vtavana changed the base branch from master to use_dpctl_rounding_funcs August 11, 2023 22:45
@vtavana vtavana changed the base branch from use_dpctl_rounding_funcs to use_dpctl_conj_in_dpnp August 11, 2023 22:51
@vtavana vtavana changed the base branch from use_dpctl_conj_in_dpnp to master August 11, 2023 22:52
@vtavana vtavana changed the base branch from master to use_dpctl_rounding_funcs August 11, 2023 22:53
@vtavana vtavana changed the title use_dpctl_rounding_funcs_in_dpnp use_dpctl_round_func_in_dpnp Aug 11, 2023
@vtavana vtavana self-assigned this Aug 14, 2023
@vtavana vtavana force-pushed the use_dpctl_rounding_funcs branch 2 times, most recently from bd6ac1e to 46d16a5 Compare August 14, 2023 17:37
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana force-pushed the use_dpctl_round_func branch 3 times, most recently from 3984319 to cab701c Compare August 16, 2023 17:57
@vtavana vtavana force-pushed the use_dpctl_rounding_funcs branch 3 times, most recently from 836ec09 to e0bf731 Compare August 18, 2023 12:53
Base automatically changed from use_dpctl_rounding_funcs to master August 18, 2023 17:19
@vtavana vtavana force-pushed the use_dpctl_round_func branch 8 times, most recently from 8c37fec to 0fd2b2c Compare August 22, 2023 22:40
@vtavana vtavana marked this pull request as ready for review August 22, 2023 23:05
@vtavana vtavana force-pushed the use_dpctl_round_func branch 2 times, most recently from e17db34 to ad67495 Compare August 23, 2023 19:58
antonwolfy
antonwolfy approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you @vtavana

@vtavana vtavana merged commit 1595ab7 into master Aug 24, 2023
21 checks passed
@vtavana vtavana deleted the use_dpctl_round_func branch August 24, 2023 19:37
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy