Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maths functions to run on Iris Xe #1502

Merged
merged 23 commits into from
Aug 5, 2023
Merged

Update maths functions to run on Iris Xe #1502

merged 23 commits into from
Aug 5, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Jul 27, 2023 •
edited by antonwolfy
Loading

This PR modifies some of the mathematical functions to run and work correctly on Iris Xe which does not support double precision floating point type.
Updated : dpnp.arctan2, dpnp.copysign, dpnp.fmod, dpnp.hypot, dpnp.maximum, dpnp.minimum, dpnp.cross
All mathematical functions will be modified in further stage so the PR is open as a draft.

Note:
The kernel dpnp_remainder_c implementation uses casting to double types.
This will be fixed in another PR

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 27, 2023
@vlad-perevezentsev vlad-perevezentsev marked this pull request as ready for review August 3, 2023 10:45
antonwolfy
antonwolfy reviewed Aug 3, 2023
View reviewed changes
dpnp/backend/src/dpnp_fptr.hpp Outdated Show resolved Hide resolved
dpnp/backend/src/dpnp_fptr.hpp Outdated Show resolved Hide resolved
dpnp/backend/src/dpnp_fptr.hpp Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit 297810e into master Aug 5, 2023
21 checks passed
@antonwolfy antonwolfy deleted the fix_test_mathematical branch August 5, 2023 15:49
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy