Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse dpctl.tensor comparison functions. #1458

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Reuse dpctl.tensor comparison functions. #1458

merged 4 commits into from
Jun 30, 2023

Conversation

npolina4
Copy link
Collaborator

Reuse dpctl.tensor implementation for equal, not_equal, less, less_equal, greater, and greater_equal functions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

antonwolfy
antonwolfy reviewed Jun 29, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/random/dpnp_algo_random.pyx Outdated Show resolved Hide resolved
dpnp/random/dpnp_algo_random.pyx Outdated Show resolved Hide resolved
@antonwolfy antonwolfy merged commit 07d3a3e into master Jun 30, 2023
@antonwolfy antonwolfy deleted the reuse_comparison_functions branch June 30, 2023 14:38
@antonwolfy antonwolfy mentioned this pull request Jul 13, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy