Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dpnp.div() implementation #1418

Merged
merged 9 commits into from
Jun 12, 2023
Merged

Improve dpnp.div() implementation #1418

merged 9 commits into from
Jun 12, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 6, 2023 •
edited
Loading

The new logic assumes to call div from pybind11 extension of OneMKL VM if possible or fully rely on dpctl.tensor implementation for divide otherwise.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy
Improve dpnp.div() implementation:
9960b60 
    - reuse dpctl.tensor.div()
    - write pybind11 extension for div() from OneMKL VM
@antonwolfy antonwolfy self-assigned this Jun 6, 2023
vlad-perevezentsev
vlad-perevezentsev approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Thanks @antonwolfy

@antonwolfy antonwolfy force-pushed the imp_div_op branch 14 times, most recently from 0c5b6e8 to 7b46d00 Compare June 12, 2023 08:34
@antonwolfy antonwolfy merged commit 1b4b671 into master Jun 12, 2023
@antonwolfy antonwolfy deleted the imp_div_op branch June 12, 2023 14:39
@antonwolfy antonwolfy mentioned this pull request Jun 13, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 left review comments

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @vlad-perevezentsev @npolina4