Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gh-1352 dpnp.sum() for empty array crashes. #1369

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Fix gh-1352 dpnp.sum() for empty array crashes. #1369

merged 5 commits into from
Apr 6, 2023

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Apr 5, 2023

Closes #1352

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@npolina4 npolina4 requested a review from vtavana April 5, 2023 07:22
@oleksandr-pavlyk
Copy link
Contributor

If the sum supports dtype output, the zeros_like call should be using it.

@npolina4 npolina4 merged commit d65a635 into master Apr 6, 2023
@npolina4 npolina4 deleted the fix-gh-1352 branch April 6, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dpnp.sum() for empty array crashes.
2 participants
@npolina4 @oleksandr-pavlyk