Add device and sycl_queue to dpnp.random.seed() & use random values if seed is None

Author: antonwolfy

dpnp/random/dpnp_iface_random.py

@@ -1464,18 +1464,35 @@ def shuffle(x1):
     return
 
 
-def seed(seed=None):
+def seed(seed=None,
+         device=None,
+         sycl_queue=None):
     """
-    Reseed a legacy mt19937 random number generator engine.
+    Reseed a legacy MT19937 random number generator engine.
+
+    Parameters
+    ----------
+    device : {None, string, SyclDevice, SyclQueue}, optional
+        An array API concept of device where an array with generated numbers will be created.
+        The `device` can be ``None`` (the default), an OneAPI filter selector string,
+        an instance of :class:`dpctl.SyclDevice` corresponding to a non-partitioned SYCL device,
+        an instance of :class:`dpctl.SyclQueue`, or a `Device` object returned by
+        :obj:`dpnp.dpnp_array.dpnp_array.device` property.
+    sycl_queue : {None, SyclQueue}, optional
+        A SYCL queue to use for an array with generated numbers.
 
     Limitations
     -----------
-    Parameter ``seed`` is supported as a scalar.
-    Otherwise, the function will use :obj:`numpy.random.seed` on the backend
-    and will be executed on fallback backend.
+    Parameter `seed` is supported as either a scalar or an array of maximumum three integer scalars.
 
     """
 
+    # update a mt19937 random number for both RandomState and legacy functionality
+    global _dpnp_random_states
+
+    sycl_queue = dpnp.get_normalized_queue_device(device=device, sycl_queue=sycl_queue)
+    _dpnp_random_states[sycl_queue] = RandomState(seed=seed, sycl_queue=sycl_queue)
+
     if not use_origin_backend(seed):
         # TODO:
         # array_like of ints for `seed`
@@ -1488,12 +1505,6 @@ def seed(seed=None):
         else:
             # TODO:
             # migrate to a single approach with RandomState class
-
-            # update a mt19937 random number for both RandomState and legacy functionality
-            global _dpnp_random_states
-            for sycl_queue in _dpnp_random_states.keys():
-                _dpnp_random_states[sycl_queue] = RandomState(seed=seed, sycl_queue=sycl_queue)
-
             dpnp_rng_srand(seed)
 
     # always reseed numpy engine also

dpnp/random/dpnp_random_state.py

@@ -76,7 +76,12 @@ class RandomState:
     """
 
     def __init__(self, seed=None, device=None, sycl_queue=None):
-        self._seed = 1 if seed is None else seed
+        if seed is None:
+            # ask NumPy to generate an array of three random integers as default seed value
+            self._seed = numpy.random.randint(low=0, high=numpy.iinfo(numpy.uint32).max + 1, size=3)
+        else:
+            self._seed = seed
+
         self._sycl_queue = dpnp.get_normalized_queue_device(device=device, sycl_queue=sycl_queue)
         self._sycl_device = self._sycl_queue.sycl_device