Skip to content

Python array API conformity workflow added #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 102 commits into from

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Aug 12, 2022

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
    Tested locally here: Array api conformity test ndgrigorian/dpctl#4

@coveralls
Copy link
Collaborator

coveralls commented Aug 12, 2022

Coverage Status

Coverage increased (+0.04%) to 81.872% when pulling a052a4e on ndgrigorian:array-api-conformity into f48cf30 on IntelPython:master.

ndgrigorian and others added 23 commits August 15, 2022 18:36
```python
import numpy as np, dpctl.tensor as dpt

dpt.asarray(np.array([1,2,3], dtype=object)) # now raises TypeError
```
The tag must contain sycl-nightly substring in it.
…figure out the data type appropriate for the device
Update array-api-conformity.yml

Moved array API conformity test to conda workflow

Fixed conflicting job names

Fixed indentation

Added PR commenting to array API conformity test

Removed redundant installation

Fixed yaml syntax

More syntax fixes

Allow-repeats for array conformity comment=false

Testing pull_request_target

Removed pull_request flag

Reverted to pull request

Formatting fix

jq install fixed

Moved array API dependency installation

Continue-on-error added to array test step

Adjusted PR message

Testing if the passed env var is being set

Testing more comment functionality

Corrected environment variable names

Removed separate file for array API workflow

Raise array API test version (json report)

Readded conformity yml to delete later

Reset cache of array API test repo

Commit with caching

Adds version to test directory (for cache)

Removed array API yml

Allow repeats false for pr comment
@ndgrigorian ndgrigorian changed the base branch from master to fix-upload-channel September 6, 2022 17:33
@ndgrigorian ndgrigorian changed the base branch from fix-upload-channel to master September 6, 2022 17:33
@oleksandr-pavlyk
Copy link
Contributor

Please ping me when this is ready. The PR should contain a single commit, unless it could be partitioned into sequence of meaningful changes to that same file.

oleksandr-pavlyk and others added 27 commits September 8, 2022 09:16
…figure out the data type appropriate for the device
Bump up cache number

Attempt to triage conda-package workflow

source conda shell definition before calling calling activate

test_examples_list must make sure to install the exact version built by build_linux step

Require dpnp>=0.10.1
Import pybind11::error_already_set into dpctl::memory namespace to work-around
compilation error due to use of not-fully qualified identified in
PYBIND11_OBJECT_CVT macro
These are DPCTLDevice_GetGlobalMemCacheSize, DPCTLDevice_GlobalMemCacheLineSize,
and DPCTLDevice_GetGlobalMemCacheType.

To support the latter, introduced DPCTLGlobalMemCacheType enum in dpctl_sycl_enum_types.h

Tests are added to test_capi target.
  * dpctl.SyclDevice.global_mem_cache_size
  * dpctl.SyclDevice.global_mem_cache_line_size
  * dpctl.SyclDevice.global_mem_cache_type

The last property output is a new enum dpctl.global_mem_cache_type
which can assume 3 values: none, read_only, and read_write
max_sub_group_size property is currently on hold due to an issue in DPC++
runtime
@ndgrigorian ndgrigorian closed this Sep 8, 2022
@ndgrigorian ndgrigorian mentioned this pull request Sep 8, 2022
5 tasks
@ndgrigorian ndgrigorian deleted the array-api-conformity branch September 8, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants