Skip to content

Added dpctl.tensor.concat feature and tests #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

npolina4
Copy link
Contributor

@npolina4 npolina4 commented Jul 26, 2022

concat() function concatenates several arrays along one of axis and follows array API spec.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Jul 26, 2022

Coverage Status

Coverage increased (+0.2%) to 81.74% when pulling 600ac20 on adding-concat-feature into 299bd7e on master.

@npolina4 npolina4 force-pushed the adding-concat-feature branch from 7220128 to 04142cd Compare July 26, 2022 21:48
@oleksandr-pavlyk oleksandr-pavlyk changed the title Adding concat feature and tests. Added dpctl.tensor.concat feature and tests Jul 27, 2022
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@oleksandr-pavlyk oleksandr-pavlyk merged commit 8e04e06 into master Jul 27, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the adding-concat-feature branch July 27, 2022 17:14
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants