Skip to content

Fix errors and warnings in asserts #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

There was a typo in one of the assertions, and numerous comparisons between signed and unsigned types.
Recent fix to build_locally.py (#835) uncovered these, and this PR fixes the error and addresses the warnings,

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.895% when pulling 458c4ea on fix-errors-and-warnings-in-asserts into 83bd76f on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 94771c4 into master May 13, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-errors-and-warnings-in-asserts branch May 13, 2022 15:15
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants