Improve coverage #818
Merged
Improve coverage #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm-cov is able to generate coverage for code in shared object library so long of object files used to link it are passed with -object argument to `llvm-cov report`. These arguments are generated using CMake generator expression, specifically TARGET_OBJECTS:DPCTLSyclInterface.
…m quick start guide
Decoupled llvm-genhtml and llvm-cov targets. Used object files in llvm-genhtml as it was done in llvm-cov target.
…test Modified workflow to use the script
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/818/index.html |
|
@oleksandr-pavlyk do you see any cases for |
1. Uses oneAPI
python scripts/build_locally.py
python scripts/build_locally.py --oneapi # this still worsk
2. Use non-standard oneAPI installation
# compiler_root/bin/ and compiler_root/bin-llvm should exist
python scripts/build_locally --compiler-root=/path/to/compiler_root
3. Use open-source bundle
python scripts/build_locally --c-compiler=clang --cxx-compiler=clang++ --compiler_root=/path/to/dpcpp_compiler
oleksandr-pavlyk
force-pushed
the
improve-coverage
branch
4 times, most recently
from
ce3fbe7 to
c545ef4
Compare
Convert two .lcov files from different runs into 2 json files, combine them in Python and then use coveralls to merge the combined result with coverage data and upload
oleksandr-pavlyk
force-pushed
the
improve-coverage
branch
from
c545ef4 to
8506332
Compare
Also removed setting of DPCTL_ENABLE_L0_PROGRAM_CREATION to default value of ON.
diptorupd
approved these changes
Apr 20, 2022
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes generation of coverage of libDPCTLSyclInterface, building ctest executable and linking it against the library, as opposed to recompiling all the library together with test files into one executable.
Thanks to @diptorupd insight on how to generate coverage for code from shared object, it becomes possible to measure coverage of the DPCTLSyclInterface library generated by calls from Python API, specifically exercised by pytest.